Lifetime reference search #6907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 17, 2020
| NavigationTarget { | ||
| file_id: src.file_id.original_file(db), | ||
| name: self.name(db).to_string().into(), | ||
| kind: LIFETIME_PARAM, |
Contributor
There was a problem hiding this comment.
Unrelated to PR, but, now that I look at it, using SyntaxKind here is abstraction sloppiness. This really should be enum DefinitionKind declated in the ide crate, and re-used by HighlightTag enum. Will probably look into fixing that.
Contributor
|
The yak is shaved! bors r+ |
Contributor
|
@Veykril Does this also encompass loop labels? They are not lifetimes, but their syntax look alike, and attempts to rename them also yield fn main() {
'a: loop { // Cannot rename 'a: No references found at position.
for i in 0..5 {
if i > 1 {
break 'a;
}
}
}
}I'd understand this belongs to another issue though. |
Member
Author
|
No, loop labels aren't implemented in this PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6787 but rewritten to make use of the HIR now. This only applies to Lifetimes, not labels. Also Higher-Ranked Trait Bounds aren't supported yet, but I feel like this PR is big enough as is which is why I left them out after noticing I forgot about them.
Supporting renaming required slight changes in the renaming module as lifetime names aren't allowed for anything but lifetimes(and labels) and vice versa for normal names.