Remove module_lang_items
#6910
Merged
Remove module_lang_items
#6910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't used anywhere except in `crate_lang_items`. Remove it to slightly reduce memory usage and simplify the code.
Contributor
Contributor
|
Hm, not sure this is entirely right, module query was a compilation
firewall. Now changing module’s items would lead to whole crate being
recomputed....
Ah, no, that’s wrong. We are looking at cratedefmap anyway, and that is
itself per-crate.
…On Thursday, 17 December 2020, bors[bot] ***@***.***> wrote:
Merged #6910 <#6910>
into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6910 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M6NVZJDUQNDODWQQOTSVFAGXANCNFSM4U6XOMUQ>
.
|
Member
|
That's the exact train of thought I went through as well 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't used anywhere except in
crate_lang_items. Remove it toslightly reduce memory usage and simplify the code.
bors r+