Skip to content

Don't expose SyntaxKind from IDE API #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2020
Merged

Don't expose SyntaxKind from IDE API #6930

merged 2 commits into from
Dec 18, 2020

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Dec 18, 2020

bors r+
🤖

@matklad
Cleaup imports
2465fa0 
ide should re-export everything it needs.
bors bot added a commit that referenced this pull request Dec 18, 2020
@bors @matklad
Merge #6930
12416c6 
6930: Don't expose SyntaxKind from IDE API r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 18, 2020

Build failed:

@matklad
Don't expose SyntaxKind from IDE API
55ba353 
SyntaxKind is somewhat of an internal type, but IDE is using it to
basically specify an icon. Let's have a dedicated entity for this
instead.
@matklad
Copy link
Contributor Author

matklad commented Dec 18, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 18, 2020

Build succeeded:

@bors bors bot merged commit 8be3f25 into rust-lang:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matklad