Better fuzzy heuristics #6946
Merged
Better fuzzy heuristics #6946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneToIgnore
force-pushed
the
better-fuzzy-heuristics
branch
from
c6d3084 to
502672c
Compare
SomeoneToIgnore
force-pushed
the
better-fuzzy-heuristics
branch
from
502672c to
0415dcd
Compare
Contributor
This is because we don't really force order of completions right now, it's the client who does the sorting. One of the things we should do around now-wish is to change that, and to move completion ordering to the server. |
matklad
reviewed
Dec 19, 2020
Contributor
Author
|
bors r=matklad |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the #6922, mainly created for a test.
Turns out our current completions tests were sorting the completions by label, I had to remove that to test the order properly and update this order in a bunch of tests (ergo the changes)