Use more Rustic highlighting specifiers #6947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Method* works for OO languages, but in rust we can also have associated constants & types, so let's move this to a modifier.
Contributor
Author
|
cc @lnicola |
Contributor
Member
|
But why? Inherent functions are now no longer marked as methods, which is probably not what users would expect. |
Contributor
Author
|
Hm, they should be marked as such:
https://github.com/rust-analyzer/rust-analyzer/pull/6947/files#diff-5432b98d7968fe0154258257763520ecf07ecc2769c9e2a55db02389f183c906R386
The goal here is to preserve the same lsp-level behavior, but have more
rust-specific insides.
…On Sat, 19 Dec 2020 at 18:20, Laurențiu Nicola ***@***.***> wrote:
But why? Inherent functions are now no longer marked as methods, which is
probably not what users would expect.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6947 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M5W2WSOO67PTQC7IODSVTAETANCNFSM4VCKHM4A>
.
|
Member
|
I'm looking at the test changes: https://github.com/rust-analyzer/rust-analyzer/pull/6947/files#diff-8104eb9eebc09900dd0ffcf4965ba5e33ac1775c21dcc6cb40db7009eadc08e7R49. (And indeed, even associated/static methods are now functions, there's a couple of them in the same file.) |
Contributor
Author
|
Hm, good question. Seems like a bug *somewhere*? Those should get an
`.associated` class now...
…On Sat, 19 Dec 2020 at 18:26, Laurențiu Nicola ***@***.***> wrote:
I'm looking at the test changes:
https://github.com/rust-analyzer/rust-analyzer/pull/6947/files#diff-8104eb9eebc09900dd0ffcf4965ba5e33ac1775c21dcc6cb40db7009eadc08e7R49
.
(And indeed, even associated/static methods are now functions, there's a
couple of them in the same file.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6947 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3MZUMKNO3PMN3SNPSCLSVTA23ANCNFSM4VCKHM4A>
.
|
Contributor
Author
|
Excellent catch, fixed by #6951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
🤖