Show enum variant on Self qualified paths #6960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Dec 21, 2020
| } | ||
| "#, | ||
| expect
There was a problem hiding this comment.
Should we really suggest Foo::Bar and Foo::Baz after Qu?
I have this nagging feeling that we're including way too much in the autocompletion results.
Member
Author
There was a problem hiding this comment.
I think we make it the clients job to filter out the completions? I'm not sure but most(if not all) completions ignore the already typed parts from what I've seen.
Contributor
There was a problem hiding this comment.
yup, we should send all completion variants.
Well, actually, now that we want to implement sorting ourselves, I think we should implement sorting ourselves (as a generic filter higher in the stack, not in each specific completion contributor), if LSP allows for that.
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes first part of #6549
Fixes #6550