Bump deps #7016
Merged
Bump deps #7016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
commented
Dec 23, 2020
| rust_ir::AdtRepr { repr_c: false, repr_packed: false } | ||
| fn adt_repr(&self, _struct_id: AdtId) -> Arc<rust_ir::AdtRepr<Interner>> { | ||
| // FIXME: keep track of these | ||
| Arc::new(rust_ir::AdtRepr { c: false, packed: false, int: None }) |
Member
Author
There was a problem hiding this comment.
I think we already remember the packedness, but I got a bit lost trying to retrieve it.
Member
Author
|
r? @flodiebold |
flodiebold
reviewed
Dec 23, 2020
crates/hir_ty/src/traits/chalk.rs
Outdated
| } | ||
| fn discriminant_type(&self, _ty: chalk_ir::Ty<Interner>) -> chalk_ir::Ty<Interner> { | ||
| // FIXME: keep track of this | ||
| unimplemented!(); |
Member
There was a problem hiding this comment.
hmm this could potentiall introduce crashes, together with the well_known_trait_from_lang_attr addition. Could you make it instead just return i32 (chalk_ir::TyKind::Scalar(Scalar::Uint(chalk_ir::IntTy::I32)).intern(&Interner))?
Member
Author
There was a problem hiding this comment.
What do you mean about well_known_trait_from_lang_attr?
Member
There was a problem hiding this comment.
Just that because of that change, this function could be called.
Member
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.