Fix macro_rules not accepting brackets or parentheses #7027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
let's put a [,( test directly over the match arm, as opposed to over the
function
…On Thu, 24 Dec 2020 at 11:27, Lukas Wirth ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#7027
Commit Summary
- Fix macro_rules not accepting brackets or parentheses
File Changes
- *M* crates/parser/src/grammar/items.rs
<https://github.com/rust-analyzer/rust-analyzer/pull/7027/files#diff-f4d4ad8964b6af5b78d3621d38b5553cd93c317741b29a6c85964a6277b59a16>
(10)
- *A* crates/syntax/test_data/parser/inline/ok/0158_macro_rules.rast
<https://github.com/rust-analyzer/rust-analyzer/pull/7027/files#diff-a4061fa70c30b3d4597f1dfdf04744a036d9d793be31212bce1a9531a0afd751>
(84)
- *A* crates/syntax/test_data/parser/inline/ok/0158_macro_rules.rs
<https://github.com/rust-analyzer/rust-analyzer/pull/7027/files#diff-20f16a248a8ca8ace186b03711f4f31ba5e9da46738117f7b182b977d2fc00d5>
(3)
Patch Links:
- https://github.com/rust-analyzer/rust-analyzer/pull/7027.patch
- https://github.com/rust-analyzer/rust-analyzer/pull/7027.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7027>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M3XIS245PSHCLXTTSTSWL3QFANCNFSM4VH6NBOQ>
.
|
lnicola
reviewed
Dec 24, 2020
| T!['{'] => { | ||
| T!['['] | T!['('] => { | ||
| token_tree(p); | ||
| p.expect(T![;]); |
Member
Author
There was a problem hiding this comment.
Only {}, []; and (); macro invocations are allowed to produce items, hence you also need the semi here.
Member
|
bors r+ |
Member
|
bors r- |
Contributor
|
Canceled. |
Member
Author
|
bors r=matklad,lnicola |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.