Add ' to trigger_characters, allowing more direct lifetime completions
#8132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does this make typing char literals more annoying? |
Member
Author
|
It shouldn't as we don't do any completions on them and we only show lifetime/label completion when they make sense. So lifetime completions are never relevant where a char literal can be typed, and for labels you could in theory want to |
Member
|
Ah, okay. I thought it might make Code show an empty completion popup or something like that. |
Member
Author
|
Nope, it doesn't. |
Member
Author
|
changelog skip |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes having to type a character after
'to complete lifetimes and labels