-
Notifications
You must be signed in to change notification settings - Fork 1.9k
internal: add integrated completion benchmark #8720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| //! Fully integrated benchmarks for rust-analyzer, which load real cargo | ||
| //! projects. | ||
| //! | ||
| //! The benchmark here is used to debug specific performance regressions. If you | ||
| //! notice that, eg, completion is slow in some specific case, you can modify | ||
| //! code here exercise this specific completion, and thus have a fast | ||
| //! edit/compile/test cycle. | ||
| //! | ||
| //! Note that "Rust Analyzer: Run" action does not allow running a single test | ||
| //! in release mode in VS Code. There's however "Rust Analyzer: Copy Run Command Line" | ||
| //! which you can use to paste the command in terminal and add `--release` manually. | ||
|
|
||
| use std::{convert::TryFrom, sync::Arc}; | ||
|
|
||
| use ide::{Change, CompletionConfig, FilePosition, TextSize}; | ||
| use ide_db::helpers::{insert_use::InsertUseConfig, merge_imports::MergeBehavior, SnippetCap}; | ||
| use test_utils::project_root; | ||
| use vfs::{AbsPathBuf, VfsPath}; | ||
|
|
||
| use crate::cli::load_cargo::{load_workspace_at, LoadCargoConfig}; | ||
|
|
||
| #[test] | ||
| fn integrated_highlighting_benchmark() { | ||
| // Don't run slow benchmark by default | ||
| if true { | ||
| return; | ||
| } | ||
|
|
||
| // Load rust-analyzer itself. | ||
| let workspace_to_load = project_root(); | ||
| let file = "./crates/ide_db/src/apply_change.rs"; | ||
|
|
||
| let cargo_config = Default::default(); | ||
| let load_cargo_config = LoadCargoConfig { | ||
| load_out_dirs_from_check: true, | ||
| wrap_rustc: false, | ||
| with_proc_macro: false, | ||
| }; | ||
|
|
||
| let (mut host, vfs, _proc_macro) = { | ||
| let _it = stdx::timeit("workspace loading"); | ||
| load_workspace_at(&workspace_to_load, &cargo_config, &load_cargo_config, &|_| {}).unwrap() | ||
| }; | ||
|
|
||
| let file_id = { | ||
| let file = workspace_to_load.join(file); | ||
| let path = VfsPath::from(AbsPathBuf::assert(file)); | ||
| vfs.file_id(&path).unwrap_or_else(|| panic!("can't find virtual file for {}", path)) | ||
| }; | ||
|
|
||
| { | ||
| let _it = stdx::timeit("initial"); | ||
| let analysis = host.analysis(); | ||
| analysis.highlight_as_html(file_id, false).unwrap(); | ||
| } | ||
|
|
||
| profile::init_from("*>100"); | ||
| // let _s = profile::heartbeat_span(); | ||
|
|
||
| { | ||
| let _it = stdx::timeit("change"); | ||
| let mut text = host.analysis().file_text(file_id).unwrap().to_string(); | ||
| text.push_str("\npub fn _dummy() {}\n"); | ||
| let mut change = Change::new(); | ||
| change.change_file(file_id, Some(Arc::new(text))); | ||
| host.apply_change(change); | ||
| } | ||
|
|
||
| { | ||
| let _it = stdx::timeit("after change"); | ||
| let _span = profile::cpu_span(); | ||
| let analysis = host.analysis(); | ||
| analysis.highlight_as_html(file_id, false).unwrap(); | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn integrated_completion_benchmark() { | ||
| // Don't run slow benchmark by default | ||
| if true { | ||
| return; | ||
| } | ||
|
|
||
| // Load rust-analyzer itself. | ||
| let workspace_to_load = project_root(); | ||
| let file = "./crates/hir/src/lib.rs"; | ||
|
|
||
| let cargo_config = Default::default(); | ||
| let load_cargo_config = LoadCargoConfig { | ||
| load_out_dirs_from_check: true, | ||
| wrap_rustc: false, | ||
| with_proc_macro: false, | ||
| }; | ||
|
|
||
| let (mut host, vfs, _proc_macro) = { | ||
| let _it = stdx::timeit("workspace loading"); | ||
| load_workspace_at(&workspace_to_load, &cargo_config, &load_cargo_config, &|_| {}).unwrap() | ||
| }; | ||
|
|
||
| let file_id = { | ||
| let file = workspace_to_load.join(file); | ||
| let path = VfsPath::from(AbsPathBuf::assert(file)); | ||
| vfs.file_id(&path).unwrap_or_else(|| panic!("can't find virtual file for {}", path)) | ||
| }; | ||
|
|
||
| { | ||
| let _it = stdx::timeit("initial"); | ||
| let analysis = host.analysis(); | ||
| analysis.highlight_as_html(file_id, false).unwrap(); | ||
| } | ||
|
|
||
| profile::init_from("*>5"); | ||
| // let _s = profile::heartbeat_span(); | ||
|
|
||
| let completion_offset = { | ||
| let _it = stdx::timeit("change"); | ||
| let mut text = host.analysis().file_text(file_id).unwrap().to_string(); | ||
| let completion_offset = | ||
| patch(&mut text, "db.struct_data(self.id)", "sel;\ndb.struct_data(self.id)") | ||
| + "sel".len(); | ||
| let mut change = Change::new(); | ||
| change.change_file(file_id, Some(Arc::new(text))); | ||
| host.apply_change(change); | ||
| completion_offset | ||
| }; | ||
|
|
||
| { | ||
| let _it = stdx::timeit("unqualified path completion"); | ||
| let _span = profile::cpu_span(); | ||
| let analysis = host.analysis(); | ||
| let config = CompletionConfig { | ||
| enable_postfix_completions: true, | ||
| enable_imports_on_the_fly: true, | ||
| add_call_parenthesis: true, | ||
| add_call_argument_snippets: true, | ||
| snippet_cap: SnippetCap::new(true), | ||
| insert_use: InsertUseConfig { | ||
| merge: Some(MergeBehavior::Full), | ||
| prefix_kind: hir::PrefixKind::ByCrate, | ||
| group: true, | ||
| }, | ||
| }; | ||
| let position = | ||
| FilePosition { file_id, offset: TextSize::try_from(completion_offset).unwrap() }; | ||
| analysis.completions(&config, position).unwrap(); | ||
| } | ||
|
|
||
| let completion_offset = { | ||
| let _it = stdx::timeit("change"); | ||
| let mut text = host.analysis().file_text(file_id).unwrap().to_string(); | ||
| let completion_offset = | ||
| patch(&mut text, "sel;\ndb.struct_data(self.id)", "self.;\ndb.struct_data(self.id)") | ||
| + "self.".len(); | ||
| let mut change = Change::new(); | ||
| change.change_file(file_id, Some(Arc::new(text))); | ||
| host.apply_change(change); | ||
| completion_offset | ||
| }; | ||
|
|
||
| { | ||
| let _it = stdx::timeit("dot completion"); | ||
| let _span = profile::cpu_span(); | ||
| let analysis = host.analysis(); | ||
| let config = CompletionConfig { | ||
| enable_postfix_completions: true, | ||
| enable_imports_on_the_fly: true, | ||
| add_call_parenthesis: true, | ||
| add_call_argument_snippets: true, | ||
| snippet_cap: SnippetCap::new(true), | ||
| insert_use: InsertUseConfig { | ||
| merge: Some(MergeBehavior::Full), | ||
| prefix_kind: hir::PrefixKind::ByCrate, | ||
| group: true, | ||
| }, | ||
| }; | ||
| let position = | ||
| FilePosition { file_id, offset: TextSize::try_from(completion_offset).unwrap() }; | ||
| analysis.completions(&config, position).unwrap(); | ||
| } | ||
| } | ||
|
|
||
| fn patch(what: &mut String, from: &str, to: &str) -> usize { | ||
| let idx = what.find(from).unwrap(); | ||
| *what = what.replacen(from, to, 1); | ||
| idx | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, how does this work?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I
uncomment this manually when I want to capture profile :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth checking for an env variable instead.