Skip to content

fix: Do not overwrite comments and attrs in trait impl completion #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

fix: Do not overwrite comments and attrs in trait impl completion #8742

merged 1 commit into from
May 6, 2021

Conversation

@Jesse-Bakker
Copy link
Contributor

@Jesse-Bakker Jesse-Bakker commented May 6, 2021

Fixes #8739

@Jesse-Bakker Jesse-Bakker force-pushed the fix-trait-impl-completion branch from 1338411 to a17fc9a Compare May 6, 2021 14:06
@Jesse-Bakker Jesse-Bakker changed the title Fix: Do not overwrite comments and attrs in trait impl completion fix: Do not overwrite comments and attrs in trait impl completion May 6, 2021
@Jesse-Bakker Jesse-Bakker force-pushed the fix-trait-impl-completion branch from a17fc9a to 10254b5 Compare May 6, 2021 14:16
@Veykril
Copy link
Member

Veykril commented May 6, 2021

lgtm!
bors r+

@bors
Copy link
Contributor

bors bot commented May 6, 2021

Build succeeded:

@bors bors bot merged commit 65bdf84 into rust-lang:master May 6, 2021
@edwin0cheng edwin0cheng mentioned this pull request May 6, 2021
Merged
bors bot added a commit that referenced this pull request May 6, 2021
@bors @edwin0cheng
Merge #8744
3b4d5df 
8744: minor: simplify  r=edwin0cheng a=edwin0cheng

cc #8742

bors r+

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
@Jesse-Bakker Jesse-Bakker mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trait method and associated type auto completion removes comments and attributes

2 participants

@Jesse-Bakker @Veykril