fix: Correctly support SelfType when searching for usages #8773
+222
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
commented
May 8, 2021
Veykril
changed the title
matklad
reviewed
May 8, 2021
| FileId(0) 28..32 | ||
| FileId(0) 50..54 | ||
| "#]], | ||
| ); |
Contributor
There was a problem hiding this comment.
That’s somewhat inconsistent indentation :)
Member
Author
There was a problem hiding this comment.
The one downside of expect-testing is rustfmt not touching it while also continuing to pass with a different indentation 😄
crates/ide_db/src/search.rs
Outdated
| let module = sema.to_module_def(root_file)?; | ||
| Some(it.ty(sema.db, module)) | ||
| } | ||
| ModuleDef::Trait(_it) => None, // FIXME turn trait into its self-type |
Contributor
There was a problem hiding this comment.
That’s tricky, but this operation doesn’t make sense. Self has surprisingly different semantics in traits and impls.
In traits, it is a type parameter which implements the trait itself (but might as well implement other traits).
in impls, it is a type alias referring to the impl’s type.
Member
Author
There was a problem hiding this comment.
Ye I didn't realize that, should definitely not do this for Self in trait defs then, changed the tests.
Member
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7443