fix: fix dependencies of build scripts #8812
Merged
+57
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Seems to be working fine after some local testing. bors r+ |
Contributor
Member
|
I'm not sure why, but this increased the number of unknown types in
|
Contributor
Author
|
hmm, its build script imports |
bors bot
added a commit
that referenced
this pull request
May 24, 2021
8970: fix: duplicate dependencies that have multiple DepKinds r=jonas-schievink a=jonas-schievink Cargo collapses identical dependencies that are listed under `[dependencies]` and `[build-dependencies]` into a single `NodeDep`. We have to undo that by duplicating the dependency for each of its listed `DepKind`s. Not doing that would incorrectly treat a dependency as `DepKind::Normal`, even though it is *also* meant to be a `DepKind::Build`. Fixes #8812 (comment) bors r+ Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Member
|
Not to complain, but there still are 4 more unknown types (64 vs. 60). I'm not sure of a way to enumerate them, though. |
Contributor
Author
|
webrender's numbers also increased slightly when the chalk unification work happened, so I'm assuming it's caused by that |
Member
|
Yeah, good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added a dependency for all targets in a package to the package's library target. This is correct for most targets, except build scripts, which run before the library crate is built. This PR removes the incorrect dependency on the library target.
We also used to treat all dependencies the same, which led to build scripts being able to use regular dependencies as well as dev-dependencies. This is also fixed by this PR, and build scripts only depend on build-dependencies.
Incorrect dependency graph:
Graph after removing incorrect dependency on the library target:
Graph after removing non-build-dependencies (final state after this PR):