internal: Refactor / clean up hir_ty tests #9346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 20, 2021
9346: Refactor / clean up hir_ty tests r=flodiebold a=flodiebold Notable changes: - unify `check_types` and `check_mismatches` into `check`, which supports both kinds of annotations (`check_types` still exists because I didn't want to change all the annotations, but uses the same implementation) - because of that, `check_types` now fails on any type mismatches; also annotations always have to hit the exact range - there's also `check_no_mismatches` for when we explicitly just want to check that there are no type mismatches without giving any annotations (`check` will fail without annotations) - test annotations can now be overlapping (they point to the nearest line that has actual code in that range): ``` // ^^^^ annotation // ^^^^^^^^^ another annotation ``` Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
Contributor
Contributor
|
Great cleanup, thanks for working on this! I wonder if, at some point, we should invest into auto-updating annotations? I've just realized that, with |
Member
Author
|
Yeah, I was considering that as well... I'm not sure how useful auto-updating these annotations will be though. I don't expect them to change that much. |
jonas-schievink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
check_typesandcheck_mismatchesintocheck, which supports both kinds of annotations (check_typesstill exists because I didn't want to change all the annotations, but uses the same implementation)check_typesnow fails on any type mismatches; also annotations always have to hit the exact rangecheck_no_mismatchesfor when we explicitly just want to check that there are no type mismatches without giving any annotations (checkwill fail without annotations)