Skip to content

internal: introduce in-place indenting API #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2021
Merged

internal: introduce in-place indenting API #9944

merged 3 commits into from
Aug 24, 2021

Conversation

@iDawer
Copy link
Contributor

@iDawer iDawer commented Aug 18, 2021

Introduce edit_in_place::Indent that uses mutable tree API and intended to replace edit::AstNodeEdit.

Closes #9903

matklad
matklad reviewed Aug 18, 2021
View reviewed changes
matklad
matklad reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2021
@bors @iDawer
Merge #9944
adb1669 
9944: internal: introduce in-place indenting API r=matklad a=iDawer

Introduce `edit_in_place::Indent` that uses mutable tree API and intended to replace `edit::AstNodeEdit`.

Closes #9903 

Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

Timed out.

@matklad
Copy link
Contributor

matklad commented Aug 24, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

Build succeeded:

@bors bors bot merged commit 6287d38 into rust-lang:master Aug 24, 2021
@iDawer iDawer deleted the syntax.in-place-indent branch September 7, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matklad matklad matklad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to in-place indenting

2 participants

@iDawer @matklad