Better warnings for types with the same name as rust types

[akshayknarayan]

Input C/C++ Header

See invocation below

Bindgen Invocation

    bindgen::builder()
        .header_contents("bug.h", "#include <stdint.h>\ntypedef uint64_t u64;")
        .generate()
        .unwrap()

Actual Results

   Compiling bindgen-typedef-primitive v0.1.0 (file:///home/jon/dev/tmp/bindgen-typedef-primitive)
error[E0391]: cycle detected when processing `u64`
   --> /home/jon/dev/tmp/cargo-target/debug/build/bindgen-typedef-primitive-177200f3c53a8948/out/bindings.rs:193:16
    |
193 | pub type u64 = u64;
    |                ^^^
    |
    = note: ...which again requires processing `u64`, completing the cycle

error: aborting due to previous error

Expected Results

This error message is rather confusing, especially when the header file for which bindings are being generated is large.
Rather, it would be nice if generating bindings for types which have the same name as rust types failed.

cc @jonhoo

[emilio]

We should probably just handle those types in rust_mangle, and ideally have a way to not have to list them there...

https://github.com/rust-lang-nursery/rust-bindgen/blob/8f8703f0122abef7be5fba33cbba629ddd1655c1/src/ir/context.rs#L841

Wanna submit a patch? :)

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[aaaaeoglnr]

Hi, highfive, I would like to try and help with this. @highfive: assign me , please.

[highfive]

Hey @aaaaeoglnr! Thanks for your interest in working on this issue. It's now assigned to you!

[jhod0]

@aaaaeoglnr are you still working on this? I added an option to do something similar, recording an error when an input header has anything with a Rust primitive type name

[kellda]

Just thinking: could this be fixed by generating core::primitive::u64 instead of just u64 ?