Don't generate accessor methods for large bitfields #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Perfect! Thanks @Tiwalun! Are you interested in hacking on bindgen some more? If so, I can help find something that would be useful :) @bors-servo r+ |
|
📌 Commit 89ef8c2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 7, 2017
Don't generate accessor methods for large bitfields This fixes #570, by not generating accessor methods for large methods.
|
☀️ Test successful - status-travis |
Contributor
Author
|
@fitzgen I'd love to, if you can recommend something. I'm still fairly new to Rust, so something not too complicated would be best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #570, by not generating accessor methods for large methods.