Revise Path type documentation for clarity
#1972
Merged
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the description of the `Path` type to clarify its usage across platforms and simplified the language. I updated src/std_misc/path.md to remove references to separate posix::Path/windows::Path and reflect that there’s a single std::path::Path. I also simplified the closing guidance to point users to Path methods and Metadata.
Collaborator
|
r? @marioidival rustbot has assigned @marioidival. Use |
I added a runtime check in the language picker so unavailable locales are hidden, preventing 404s like the Spanish URL on doc.rust-lang.org. This keeps working languages (ja/zh) visible and avoids broken links when a locale isn’t deployed. To verify locally - English-only build: run mdbook serve and confirm the menu hides ja/zh/es. - Japanese build: MDBOOK_BOOK__LANGUAGE=ja mdbook serve and confirm only ja (and any other deployed locales) remain. - Spanish build: MDBOOK_BOOK__LANGUAGE=es mdbook serve and confirm es remains and others hide.
Contributor
Author
|
Please check PR, I added a runtime check in the language picker so unavailable locales are hidden, preventing 404s like the Spanish URL on doc.rust-lang.org. This keeps working languages (ja/zh) visible and avoids broken links when a locale isn’t deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the description of the
Pathtype to clarify its usage across platforms and simplified the language.I updated src/std_misc/path.md to remove references to separate posix::Path/windows::Path and reflect that there’s a single std::path::Path. I also simplified the closing guidance to point users to Path methods and Metadata.