Skip to content

Conversation

NyCodeGHG
Copy link

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: none

Hi!
I'm currently working on a problem with our rust support in NixOS/nixpkgs.
We need a way to point cargo-clippy to a wrapper of clippy-driver which provides it with a correct sysroot.
I've came up with this patch to solve it, but we would want to upstream it, so here I am :)
Feel free to let me know what you think of this or if you have a better idea.

Relevant: NixOS/nixpkgs#434028

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 31, 2025
@samueltardieu
Copy link
Member

Closing since this after discussion on the NixOS side this can be resolved with nixpkgs wrapper.

@NyCodeGHG Don't hesitate to reopen if that's not the case.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 31, 2025
@NyCodeGHG NyCodeGHG deleted the clippy-driver-env-var branch August 31, 2025 19:08
@Jarcho
Copy link
Contributor

Jarcho commented Aug 31, 2025

From reading the issue I'm not really clear why you don't just have a wrapper around both cargo-clippy and clippy-driver that sets SYSROOT.

Edit: I've been beaten to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants