Consider labels of inline asm as conditionally executed #15676
Merged
+94
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issue15673
branch
from
7b1d6e9 to
d94a9fe
Compare
This comment has been minimized.
This comment has been minimized.
|
r? clippy |
samueltardieu
force-pushed
the
issue15673
branch
from
d94a9fe to
2b6ed3b
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
r? clippy |
samueltardieu
force-pushed
the
issue15673
branch
from
2b6ed3b to
5e73286
Compare
Alexendoo
reviewed
Oct 27, 2025
tests/ui/never_loop.rs
Outdated
| //~v never_loop | ||
| loop { | ||
| // We don't check the applicability in tests, but this should | ||
| // be `Applicability::MaybeIncorrect` because of the `break` |
There was a problem hiding this comment.
Is this working currently or a FIXME?
There was a problem hiding this comment.
I can't figure out why I wrote this, so I removed it. Moreover, no suggestion is proposed here, so applicability doesn't matter.
Since an `asm!()` statement is mostly unknown, as we do not know what it does, consider all labels' `break` as being conditionally executed only.
samueltardieu
force-pushed
the
issue15673
branch
from
5e73286 to
a5b3c44
Compare
Alexendoo
approved these changes
Oct 27, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since an
asm!()statement is mostly unknown, as we do not know what it does, consider all labels'breakas being conditionally executed only.Fixes #15673
changelog: [
never_loop]: do not considerbreaklabels used inasm!()as being unconditionally executed as they might not be