Skip to content

docs: add note about Cargo.toml lint config #15700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add note about Cargo.toml lint config #15700

wants to merge 1 commit into from

Conversation

code-with-aneesh
Copy link

@code-with-aneesh code-with-aneesh commented Sep 18, 2025 •
edited by rustbot
Loading

changelog: [clippy]: clarified that [lints.clippy] in Cargo.toml only sets lint levels, and other configurations must go in clippy.toml
fixes #12164

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

flip1995 is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@code-with-aneesh
Copy link
Author

r? nk9

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

Failed to set assignee to nk9: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

flip1995
flip1995 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remove the commented out notes before merging. (Please squash that into the existing commit)

View changes since this review

book/src/configuration.md Outdated
[lints.clippy]
enum_glob_use = "deny"
```
<!-- > **Note:** The `#[lints.clippy]` table in `Cargo.toml` can only be used to set lint levels (`allow`, `warn`, `deny`). To configure a lint's specific behavior (e.g., providing a list of allowed values), you must use a separate `clippy.toml` configuration file. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

book/src/configuration.md Outdated
Comment on lines 109 to 110
<!--
> **Note:** This should only be used in cases where other solutions, like `#[allow(clippy::all)]`, are not sufficient. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuring clippy in Cargo.toml missing from documentation?

3 participants

@code-with-aneesh @rustbot @flip1995