Clarify strlen_on_c_strings documentation
#15711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
|
@Alexendoo lemme know if I should change something :) |
Alexendoo
reviewed
Oct 5, 2025
Comment on lines
-17
to
+18
| /// This avoids calling an unsafe `libc` function. | ||
| /// Currently, it also avoids calculating the length. | ||
| /// `libc::strlen` requires an unsafe block, which we don't really need if all | ||
| /// we want to know is the length of the string. |
There was a problem hiding this comment.
I think phrase it more confidently as removing a call to an unsafe function rather than potentially removing an unsafe block
There was a problem hiding this comment.
@Alexendoo how does something like this sound?
libc::strlenis an unsafe function, which we don't need to call if all we want to know is the length of the c-string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original documentation had me confused for a couple of minutes. Now it should be more or less unambiguous.
changelog: none