Skip to content

op_ref: clean-up, overhaul diagnostics #15869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

op_ref: clean-up, overhaul diagnostics #15869

wants to merge 5 commits into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 12, 2025

changelog: [op_ref]: give suggestions with smaller diffs

@ada4a
misc: reduce indentation
b1b9667 
kept as a separate commit for a better diff
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a added 2 commits October 12, 2025 12:38
@ada4a
clean-up
96ada86 
- make `are_equal` take both pairs, to avoid finding the `DefId` twice
- match on `expr.kind` instead of `&expr.kind`
- extract `{left,right}_ty` into variables
@ada4a
make suggestions verbose
cbe8a71
ada4a added 2 commits October 12, 2025 13:07
@ada4a
fix: actually use the applicabilitys
5a6e664
@ada4a
only highlight the reference to remove
389d4fe 
NOTE: the change in diagnostics is (unfortunately only) visible when
running `cargo dev lint`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @rustbot @y21