Skip to content

Fix if_not_else wrong unmangled macros #15931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix if_not_else wrong unmangled macros #15931

wants to merge 1 commit into from
+99 −16

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Oct 21, 2025 •
edited by rustbot
Loading

Closes #15924

changelog: [if_not_else] fix wrongly unmangled macros

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a
ada4a suggested changes Oct 25, 2025
View reviewed changes
Copy link
Contributor

@ada4a ada4a left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good:) Left some minor comments

View changes since this review

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ada4a ada4a ada4a requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

partial macro expansion in suggestion for if_not_else lint

4 participants

@profetia @rustbot @ada4a @y21