Skip to content

Fix undocumented_unsafe_blocks false positive on a multi-line attribute between // SAFETY and unsafe #15945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undocumented_unsafe_blocks false positive on a multi-line attribute between // SAFETY and unsafe #15945

wants to merge 1 commit into from
+68 −14

Conversation

@heshanpadmasiri
Copy link
Contributor

@heshanpadmasiri heshanpadmasiri commented Oct 24, 2025 •
edited by rustbot
Loading

changelog: [undocumented_unsafe_blocks]: Fix false positive on a multi-line attribute between // SAFETY and unsafe

fixes #15915

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

Lintcheck changes for dfd6d0a

Lint Added Removed Changed
clippy::undocumented_unsafe_blocks 6 0 0
clippy::unnecessary_safety_comment 8 0 0

This comment will be updated if you push new changes

@heshanpadmasiri heshanpadmasiri force-pushed the fix-15915 branch 4 times, most recently from 927a0ad to 9a0af9e Compare October 24, 2025 13:34
@heshanpadmasiri heshanpadmasiri marked this pull request as ready for review October 24, 2025 15:30
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@llogiq llogiq

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: undocumented_unsafe_blocks false positive on a multi-line attribute between // SAFETY and unsafe

3 participants

@heshanpadmasiri @rustbot @llogiq