Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 7, 2025

Supersedes #15962

changelog: none

r? @Jarcho

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 7, 2025
@ada4a ada4a force-pushed the unnecessary_mut_passed-2 branch from d0eb5af to b258f9d Compare November 7, 2025 20:12
@ada4a ada4a changed the title unnecessary_mut_passed: remove the intent to lint &raw references chore(unnecessary_mut_passed): remove the intent to lint &raw references Nov 7, 2025
@ada4a ada4a force-pushed the unnecessary_mut_passed-2 branch from b258f9d to 6104c50 Compare November 7, 2025 20:22
@Jarcho
Copy link
Contributor

Jarcho commented Nov 7, 2025

There should still be a negative test for takes_raw_const(&raw mut _).

@ada4a ada4a force-pushed the unnecessary_mut_passed-2 branch from 6104c50 to b59b2fd Compare November 8, 2025 09:15
@ada4a ada4a changed the title chore(unnecessary_mut_passed): remove the intent to lint &raw references chore(unnecessary_mut_passed): show the intention not to lint &raw references Nov 8, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Nov 8, 2025

I mean that wouldn't help if someone adds the lint under a different name (but not warn-by-default), but I guess it's better than nothing

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This should prevent someone from trying to extend the lint without realizing it's not semantically equivalent.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Nov 8, 2025
Merged via the queue into rust-lang:master with commit d154da9 Nov 8, 2025
9 of 10 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 8, 2025
@ada4a ada4a deleted the unnecessary_mut_passed-2 branch November 8, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants