Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 12, 2025

cc rust-lang/rust#148190 @flip1995 @RalfJung

This is a bit of a hack in that it hardcodes the list of crates with stability attributes. This shouldn't be a big deal since that isn't a set that changes very frequently and an internal lint could detect when that happens.

The fixmes added aren't new issues and shouldn't get in the way of unblocking the upstream issue.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thanks!

@RalfJung I'll do a Clippy->Rust sync tomorrow, which should then already unblock that part of your PR. The other half we'll then probably fix in the Rust repo.

View changes since this review

@flip1995 flip1995 added this pull request to the merge queue Nov 12, 2025
@flip1995
Copy link
Member

r? flip1995

@rustbot rustbot assigned flip1995 and unassigned samueltardieu Nov 12, 2025
@github-actions
Copy link

Lintcheck changes for a537e86

Lint Added Removed Changed
clippy::incompatible_msrv 0 6 0

This comment will be updated if you push new changes

Merged via the queue into rust-lang:master with commit da2a220 Nov 12, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants