Skip to content

fix(equatable_if_let): don't suggest = in const context #16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix(equatable_if_let): don't suggest = in const context #16092

merged 1 commit into from
Nov 17, 2025

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 14, 2025

Supersedes #15482

I wasn't able to get is_const_method to work, so for now we just don't suggest = in const context.

changelog: [equatable_if_let]: don't suggest = in const context

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a mentioned this pull request Nov 14, 2025
Closed
dswij
dswij approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@dswij dswij added this pull request to the merge queue Nov 17, 2025
Merged via the queue into rust-lang:master with commit abc17b3 Nov 17, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 17, 2025
@ada4a ada4a deleted the 15376-equatable-if-let-simple branch November 17, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @rustbot @dswij