lint #1674: lifetimed types exclusion #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
suggested changes
Aug 22, 2017
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
You need to rerun cargo test and tests/ui/update-all-references.sh
clippy_lints/src/use_self.rs
Outdated
| path.segments | ||
| .last() | ||
| .expect("segments should be composed of at least 1 element") | ||
| .unwrap() |
Contributor
There was a problem hiding this comment.
Why did you downgrade the message?
Contributor
Author
There was a problem hiding this comment.
I added another expect() call with the same message. I thought the message doesn't provide additional debug information, it repeats what the code is trying. So I removed them. Should I put them back?
Contributor
There was a problem hiding this comment.
Should I put them back?
Yep. Dogfood would have complained anyway ;)
I added another expect() call with the same message. I thought the message doesn't provide additional debug information,
You can always improve on the message ;)
add expect() message and update test results
oli-obk
approved these changes
Aug 23, 2017
Contributor
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
use_selflint (issue #1674) causes false positives on "lifetimed" structures. This excludes them from linting for now. See PR #1965.