Fix single_char_pattern for \n, \t, etc. #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single characters that are escaped weren't being searched / replaced correctly in the hint string, so it was saying to replace, say, `"\n"` with `"\n"` rather than `'\n'`.
killercup
reviewed
Mar 2, 2018
| error: single-character string constant used as pattern | ||
| --> $DIR/single_char_pattern.rs:39:13 | ||
| | | ||
| 39 | x.split("/n"); |
Contributor
There was a problem hiding this comment.
huh why is this a forward slash here
Contributor
Author
There was a problem hiding this comment.
The output was correct but the test required this.
There was a problem hiding this comment.
As I understand it, this is required due to compiletest normalization.
https://github.com/rust-lang/rust/blob/master/src/test/COMPILER_TESTS.md#normalization
It looks like it does that due to path differences on Windows. Yes, it's weird.
Contributor
|
Thanks! Amazing that this didn't show up as an issue before. I would've thought splitting by escaped chars would be more common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single characters that are escaped weren't being searched / replaced
correctly in the hint string, so it was saying to replace, say,
"\n"with"\n"rather than'\n'.