Skip to content

Omit build metadata from versions in generated Cargo.toml #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2022
Merged

Omit build metadata from versions in generated Cargo.toml #824

merged 1 commit into from
Jul 2, 2022

Conversation

@dtolnay
Copy link
Member

@dtolnay dtolnay commented Jun 29, 2022

Prior to this, top-crates would serialize version reqs like this:

[dependencies.foo]
package = "foo"
version = "=1.2.3+whatever"

which would then stick a warning into the output every single time the playground compiles anything, whether or not that crate was ever used.

warning: version requirement `=1.2.3+whatever` for dependency `foo` includes
semver metadata which will be ignored, removing the metadata is recommended
to avoid confusion

Note that we'll still keep the build metadata in generated crate-information.json, just not in Cargo.toml.

@dtolnay
Omit build metadata from versions in generated Cargo.toml
a76a4f4 
Prior to this, top-crates would serialize version reqs like this:

    [dependencies.foo]
    package = "foo"
    version = "=1.2.3+whatever"

which would then stick a warning into the output every single time the
playground compiles anything, whether or not that crate was ever used.

    warning: version requirement `=1.2.3+whatever` for dependency `foo` includes
    semver metadata which will be ignored, removing the metadata is recommended
    to avoid confusion
@shepmaster shepmaster merged commit c8c0180 into rust-lang:master Jul 2, 2022
@dtolnay dtolnay deleted the versionmeta branch July 2, 2022 01:33
jiegec added a commit to thu-cs-lab/rust-playground that referenced this pull request Aug 20, 2022
@jiegec
Squashed commit of the following:
2f523a8 
commit 76cfa25
Merge: c8c0180 4763493
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sat Jul 2 20:32:09 2022 -0400

    Merge pull request rust-lang#816 from dtolnay-contrib/token

commit 4763493
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:08:42 2022 -0700

    Make a module to eliminate typos in repeating the environment variable names

commit 4fa0b11
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:04:32 2022 -0700

    Add a warning on startup if PLAYGROUND_GITHUB_TOKEN unset

commit b20dfcc
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 16:06:52 2022 -0700

    Make PLAYGROUND_GITHUB_TOKEN optional

commit c8c0180
Merge: 6f99f90 a76a4f4
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:32:17 2022 -0400

    Merge pull request rust-lang#824 from dtolnay-contrib/versionmeta

commit 6f99f90
Merge: 806ce3e e80cef1
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:30:48 2022 -0400

    Merge pull request rust-lang#818 from dtolnay-contrib/topfmt

commit a76a4f4
Author: David Tolnay <dtolnay@gmail.com>
Date:   Tue Jun 28 21:51:13 2022 -0700

    Omit build metadata from versions in generated Cargo.toml

    Prior to this, top-crates would serialize version reqs like this:

        [dependencies.foo]
        package = "foo"
        version = "=1.2.3+whatever"

    which would then stick a warning into the output every single time the
    playground compiles anything, whether or not that crate was ever used.

        warning: version requirement `=1.2.3+whatever` for dependency `foo` includes
        semver metadata which will be ignored, removing the metadata is recommended
        to avoid confusion

commit e80cef1
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:50:27 2022 -0700

    Format top-crates crate with rustfmt

commit 8a77fdf
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:48:47 2022 -0700

    Add CI to check formatting of top-crates crate

commit 806ce3e
Merge: f604243 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 13:34:01 2022 -0400

    Merge pull request rust-lang#812 from integer32llc/maint

    Maintenance

commit 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:47:47 2022 -0400

    Remove vestigial `fut` module

commit 2c18b95
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:40:50 2022 -0400

    Upgrade ui backend semver dependencies

commit ae209d8
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:45 2022 -0400

    Upgrade modify-cargo-toml semver dependencies

commit 62a8927
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:03 2022 -0400

    Update crates available in the playground

commit 6dbf79b
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:34:09 2022 -0400

    Upgrade top-crates semver dependencies

Change-Id: I318268509c46ce383d927a684c06d5328474f86c
jiegec added a commit to thu-cs-lab/rust-playground that referenced this pull request Aug 20, 2022
@jiegec
Squashed commit of the following:
e04d12f 
commit 5ff43d7
Merge: 76cfa25 f566376
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Jul 5 20:55:38 2022 -0400

    Merge pull request rust-lang#827 from dtolnay-contrib/uiroot

commit f566376
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 18:12:02 2022 -0700

    Make PLAYGROUND_UI_ROOT optional

commit 76cfa25
Merge: c8c0180 4763493
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sat Jul 2 20:32:09 2022 -0400

    Merge pull request rust-lang#816 from dtolnay-contrib/token

commit 4763493
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:08:42 2022 -0700

    Make a module to eliminate typos in repeating the environment variable names

commit 4fa0b11
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:04:32 2022 -0700

    Add a warning on startup if PLAYGROUND_GITHUB_TOKEN unset

commit b20dfcc
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 16:06:52 2022 -0700

    Make PLAYGROUND_GITHUB_TOKEN optional

commit c8c0180
Merge: 6f99f90 a76a4f4
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:32:17 2022 -0400

    Merge pull request rust-lang#824 from dtolnay-contrib/versionmeta

commit 6f99f90
Merge: 806ce3e e80cef1
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:30:48 2022 -0400

    Merge pull request rust-lang#818 from dtolnay-contrib/topfmt

commit a76a4f4
Author: David Tolnay <dtolnay@gmail.com>
Date:   Tue Jun 28 21:51:13 2022 -0700

    Omit build metadata from versions in generated Cargo.toml

    Prior to this, top-crates would serialize version reqs like this:

        [dependencies.foo]
        package = "foo"
        version = "=1.2.3+whatever"

    which would then stick a warning into the output every single time the
    playground compiles anything, whether or not that crate was ever used.

        warning: version requirement `=1.2.3+whatever` for dependency `foo` includes
        semver metadata which will be ignored, removing the metadata is recommended
        to avoid confusion

commit e80cef1
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:50:27 2022 -0700

    Format top-crates crate with rustfmt

commit 8a77fdf
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:48:47 2022 -0700

    Add CI to check formatting of top-crates crate

commit 806ce3e
Merge: f604243 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 13:34:01 2022 -0400

    Merge pull request rust-lang#812 from integer32llc/maint

    Maintenance

commit 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:47:47 2022 -0400

    Remove vestigial `fut` module

commit 2c18b95
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:40:50 2022 -0400

    Upgrade ui backend semver dependencies

commit ae209d8
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:45 2022 -0400

    Upgrade modify-cargo-toml semver dependencies

commit 62a8927
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:03 2022 -0400

    Update crates available in the playground

commit 6dbf79b
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:34:09 2022 -0400

    Upgrade top-crates semver dependencies

Change-Id: I155d78bb3c328661404607201fd9e17dbb8cb414
jiegec added a commit to thu-cs-lab/rust-playground that referenced this pull request Aug 20, 2022
@jiegec
Squashed commit of the following:
a9fce26 
commit c42e79a
Merge: 100bc9f 6de99dd
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 15:24:52 2022 -0400

    Merge pull request rust-lang#835 from integer32llc/maint

commit 6de99dd
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 12:52:29 2022 -0400

    Update test error text for Rust 1.63

commit b207787
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 12:33:59 2022 -0400

    Upgrade test semver dependencies

commit aa3116c
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:22:04 2022 -0400

    Upgrade modify-cargo-toml semver dependencies

commit e8d8e6d
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:19:42 2022 -0400

    Upgrade to octocrab 0.17

commit 34d1bdf
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:17:50 2022 -0400

    Upgrade ui backend semver dependencies

commit e4aff0f
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:17:15 2022 -0400

    Update crates available in the playground

commit 754d045
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:15:47 2022 -0400

    Update top-crates to Cargo 0.64

commit 93cb4f9
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Aug 16 11:14:07 2022 -0400

    Upgrade top-crates semver dependencies

commit 100bc9f
Merge: da0bdce 5d52ff9
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Wed Jul 13 19:38:18 2022 -0400

    Merge pull request rust-lang#826 from dtolnay-contrib/procmacro

commit 5d52ff9
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 15:50:43 2022 -0700

    Support #![crate_type = "proc-macro"]

commit e33f46b
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Jul 12 20:38:06 2022 -0400

    Upgrade test semver dependencies

commit da0bdce
Merge: 5ff43d7 b7d4914
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sat Jul 9 21:36:46 2022 -0400

    Merge pull request rust-lang#825 from dtolnay-contrib/resolver

    Speed up base build and shrink image

commit b7d4914
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Jul 5 21:36:34 2022 -0400

    Update crates available in the playground and unify features

commit 5ff43d7
Merge: 76cfa25 f566376
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Tue Jul 5 20:55:38 2022 -0400

    Merge pull request rust-lang#827 from dtolnay-contrib/uiroot

commit 999d2f7
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 17:10:35 2022 -0700

    Constrain "host" and "target" dependencies to have identical features

commit 000b25b
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 16:25:57 2022 -0700

    Override build dependencies to build with 1 codegen unit instead of 256

commit f566376
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 18:12:02 2022 -0700

    Make PLAYGROUND_UI_ROOT optional

commit 76cfa25
Merge: c8c0180 4763493
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sat Jul 2 20:32:09 2022 -0400

    Merge pull request rust-lang#816 from dtolnay-contrib/token

commit 6015639
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 16:22:56 2022 -0700

    Compute the transitive closure of all dependencies and features

commit c8f7526
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 16:21:56 2022 -0700

    Clean up platform-specific deps filtering

commit e05af79
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 16:19:41 2022 -0700

    Apply features from the custom metadata during every transitive resolve

commit 970c25e
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:53:25 2022 -0700

    Change all stages to operate on the same map type, to be loopable

commit 1b602a2
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:52:34 2022 -0700

    Use nicer way to get crate name of the library target

commit 4b618a8
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:41:41 2022 -0700

    Factor out compute_transitive_dependencies

commit 14057be
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:37:49 2022 -0700

    Factor out generate_dependency_specs

commit 97c0770
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:32:36 2022 -0700

    Factor out generate_crate_information

commit 6a0427b
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:29:12 2022 -0700

    Factor out populate_initial_direct_dependencies

commit 69e8677
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:23:15 2022 -0700

    Factor out package downloading into a bulk_download function

commit 8163529
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:18:13 2022 -0700

    Use InternedString to mesh better with Cargo's data structures

commit a189449
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:05:32 2022 -0700

    Improve readability of args of some messy function calls

commit e8db587
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 15:01:33 2022 -0700

    Factor out global Cargo state into a struct

commit 86cd4ff
Author: David Tolnay <dtolnay@gmail.com>
Date:   Sat Jul 2 14:56:21 2022 -0700

    Rename variables involved in TargetInfo

commit 4763493
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:08:42 2022 -0700

    Make a module to eliminate typos in repeating the environment variable names

commit 4fa0b11
Author: David Tolnay <dtolnay@gmail.com>
Date:   Thu Jun 23 11:04:32 2022 -0700

    Add a warning on startup if PLAYGROUND_GITHUB_TOKEN unset

commit b20dfcc
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 16:06:52 2022 -0700

    Make PLAYGROUND_GITHUB_TOKEN optional

commit c8c0180
Merge: 6f99f90 a76a4f4
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:32:17 2022 -0400

    Merge pull request rust-lang#824 from dtolnay-contrib/versionmeta

commit 6f99f90
Merge: 806ce3e e80cef1
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Fri Jul 1 21:30:48 2022 -0400

    Merge pull request rust-lang#818 from dtolnay-contrib/topfmt

commit a76a4f4
Author: David Tolnay <dtolnay@gmail.com>
Date:   Tue Jun 28 21:51:13 2022 -0700

    Omit build metadata from versions in generated Cargo.toml

    Prior to this, top-crates would serialize version reqs like this:

        [dependencies.foo]
        package = "foo"
        version = "=1.2.3+whatever"

    which would then stick a warning into the output every single time the
    playground compiles anything, whether or not that crate was ever used.

        warning: version requirement `=1.2.3+whatever` for dependency `foo` includes
        semver metadata which will be ignored, removing the metadata is recommended
        to avoid confusion

commit e80cef1
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:50:27 2022 -0700

    Format top-crates crate with rustfmt

commit 8a77fdf
Author: David Tolnay <dtolnay@gmail.com>
Date:   Wed Jun 22 22:48:47 2022 -0700

    Add CI to check formatting of top-crates crate

commit 806ce3e
Merge: f604243 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 13:34:01 2022 -0400

    Merge pull request rust-lang#812 from integer32llc/maint

    Maintenance

commit 4944ad5
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:47:47 2022 -0400

    Remove vestigial `fut` module

commit 2c18b95
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:40:50 2022 -0400

    Upgrade ui backend semver dependencies

commit ae209d8
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:45 2022 -0400

    Upgrade modify-cargo-toml semver dependencies

commit 62a8927
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:39:03 2022 -0400

    Update crates available in the playground

commit 6dbf79b
Author: Jake Goulding <jake.goulding@integer32.com>
Date:   Sun Jun 12 09:34:09 2022 -0400

    Upgrade top-crates semver dependencies

Change-Id: I874692257c822d3bf67c90706c6a0a1b7535eaf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shepmaster shepmaster shepmaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtolnay @shepmaster