Avoid loading a snippet and render the literal directly

Author: oli-obk

compiler/rustc_lint/src/types/literal.rs

@@ -284,11 +284,7 @@ fn lint_int_literal<'tcx>(
         }
 
         let span = if negative { type_limits.negated_expr_span.unwrap() } else { span };
-        let lit = cx
-            .sess()
-            .source_map()
-            .span_to_snippet(span)
-            .unwrap_or_else(|_| if negative { format!("-{v}") } else { v.to_string() });
+        let lit = if negative { format!("-{v}") } else { v.to_string() };
         // FIXME: Don't suggest unsigned types for negative literals
         let help = get_type_suggestion(cx.typeck_results().node_type(hir_id), v, negative)
             .map(|suggestion_ty| OverflowingIntHelp { suggestion_ty });

tests/ui/enum/enum-discrim-too-small2.stderr

@@ -27,7 +27,7 @@ error: literal out of range for `i32`
 LL |     Ci32 = 3_000_000_000,
    |            ^^^^^^^^^^^^^
    |
-   = note: the literal `3_000_000_000` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
+   = note: the literal `3000000000` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
    = help: consider using the type `u32` instead
 
 error: literal out of range for `i64`

tests/ui/lint/lint-type-overflow.stderr

@@ -43,7 +43,7 @@ error: literal out of range for `i8`
 LL |     let x3: i8 = -(129);
    |                  ^^^^^^
    |
-   = note: the literal `-(129)` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `-129` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `i16` instead
 
 error: literal out of range for `i8`
@@ -70,7 +70,7 @@ error: literal out of range for `i8`
 LL |     let x = 128_i8;
    |             ^^^^^^
    |
-   = note: the literal `128_i8` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `128` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `u8` instead
 
 error: literal out of range for `i8`
@@ -79,7 +79,7 @@ error: literal out of range for `i8`
 LL |     let x = -129_i8;
    |             ^^^^^^^
    |
-   = note: the literal `-129_i8` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `-129` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `i16` instead
 
 error: literal out of range for `i32`
@@ -97,7 +97,7 @@ error: literal out of range for `i32`
 LL |     let x = 2147483648_i32;
    |             ^^^^^^^^^^^^^^
    |
-   = note: the literal `2147483648_i32` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
+   = note: the literal `2147483648` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
    = help: consider using the type `u32` instead
 
 error: literal out of range for `i32`
@@ -115,7 +115,7 @@ error: literal out of range for `i32`
 LL |     let x = -2147483649_i32;
    |             ^^^^^^^^^^^^^^^
    |
-   = note: the literal `-2147483649_i32` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
+   = note: the literal `-2147483649` does not fit into the type `i32` whose range is `-2147483648..=2147483647`
    = help: consider using the type `i64` instead
 
 error: literal out of range for `i32`
@@ -133,7 +133,7 @@ error: literal out of range for `i64`
 LL |     let x = 9223372036854775808_i64;
    |             ^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = note: the literal `9223372036854775808_i64` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
+   = note: the literal `9223372036854775808` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
    = help: consider using the type `u64` instead
 
 error: literal out of range for `i64`
@@ -142,7 +142,7 @@ error: literal out of range for `i64`
 LL |     let x = 18446744073709551615_i64;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = note: the literal `18446744073709551615_i64` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
+   = note: the literal `18446744073709551615` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
    = help: consider using the type `u64` instead
 
 error: literal out of range for `i64`
@@ -160,7 +160,7 @@ error: literal out of range for `i64`
 LL |     let x = -9223372036854775809_i64;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = note: the literal `-9223372036854775809_i64` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
+   = note: the literal `-9223372036854775809` does not fit into the type `i64` whose range is `-9223372036854775808..=9223372036854775807`
    = help: consider using the type `i128` instead
 
 error: aborting due to 18 previous errors

tests/ui/lint/lint-type-overflow2.stderr

@@ -18,7 +18,7 @@ error: literal out of range for `i8`
 LL |     let x2: i8 = --128;
    |                  ^^^^^
    |
-   = note: the literal `--128` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `128` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `u8` instead
 note: the lint level is defined here
   --> $DIR/lint-type-overflow2.rs:3:9

tests/ui/lint/type-overflow.stderr

@@ -4,7 +4,7 @@ warning: literal out of range for `i8`
 LL |     let error = 255i8;
    |                 ^^^^^
    |
-   = note: the literal `255i8` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `255` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `u8` instead
 note: the lint level is defined here
   --> $DIR/type-overflow.rs:2:9
@@ -104,7 +104,7 @@ warning: literal out of range for `i8`
 LL |     let fail = 340282366920938463463374607431768211455i8;
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = note: the literal `340282366920938463463374607431768211455i8` does not fit into the type `i8` whose range is `-128..=127`
+   = note: the literal `340282366920938463463374607431768211455` does not fit into the type `i8` whose range is `-128..=127`
    = help: consider using the type `u128` instead
 
 warning: literal out of range for `i32`