-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Implement TryFrom<char>
for usize
.
#146792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Failed to set assignee to
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
@rustbot label +T-libs-api -T-libs needs-fcp r? libs-api |
This comment has been minimized.
This comment has been minimized.
226e29a
to
23ae20b
Compare
This comment has been minimized.
This comment has been minimized.
23ae20b
to
cb66ec2
Compare
This comment has been minimized.
This comment has been minimized.
cb66ec2
to
306fad6
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@rfcbot fcp merge |
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Feature gate:
usize_try_from_char
.This PR implements
TryFrom<char>
forusize
.usize
is currently the only, unsigned, integral, type to not implementTryFrom<char>
. Technically, this conversion is trivial and can already be expressed with some indirection.I think it useful to be able to describe this set of types with this interface.