-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Open
Labels
A-visibilityArea: Visibility / privacyArea: Visibility / privacyC-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
pub struct Public;
struct Private;
impl From<Private> for Public {
fn from(_: Private) -> Self {
unimplemented!()
}
}
The rustdoc of Public
displays a From
impl that cannot be invoked by users of the crate.
I'm sure there are lots of edge cases to consider, but this is a common pattern especially for error types for use with ?
. It would be nice to hide such impls from rustdoc without requiring the crate author to tag them with #[doc(hidden)]
.
This came up during the libz blitz evaluation of the reqwest crate. seanmonstar/reqwest#106
Metadata
Metadata
Assignees
Labels
A-visibilityArea: Visibility / privacyArea: Visibility / privacyC-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.