Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSource is missing from docs for crates that use a procedural macro #43371
Comments
jdm
added
the
T-rustdoc
label
Jul 20, 2017
This comment has been minimized.
This comment has been minimized.
|
Minimal reproduction: extern crate heapsize;
#[macro_use] extern crate heapsize_derive;
#[derive(HeapSizeOf)]
pub struct Range;[package]
name = "foo"
version = "0.1.0"
authors = ["Josh Matthews <josh@joshmatthews.net>"]
[dependencies]
heapsize = "0.4"
heapsize_derive = "0.1"If I remove the |
jdm
added
the
regression-from-stable-to-nightly
label
Jul 20, 2017
This comment has been minimized.
This comment has been minimized.
|
If I use |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
My money is on #40939. |
jdm
referenced this issue
Jul 20, 2017
Closed
Change in behavior of `include!` in doctests on nightly #43153
jdm
added
regression-from-stable-to-beta
and removed
regression-from-stable-to-nightly
labels
Jul 20, 2017
This comment has been minimized.
This comment has been minimized.
|
cc @jseyfried, @nrc |
This comment has been minimized.
This comment has been minimized.
|
I believe the issue is that (since #40939) we no longer accurately track expansion info for names declared in a macro. That means that tools think some names are hand-written, when they are macro generated (this is also causing problems for the RLS). #43179 was meant to fix this, but it did not (at least not for all cases). I haven't looked into the details. |
nrc
referenced this issue
Jul 25, 2017
Merged
proc_macro: implement `TokenTree`, `TokenKind`, hygienic `quote!`, and other API #40939
This comment has been minimized.
This comment has been minimized.
|
Not just names. Clippy gets confused by the |
Mark-Simulacrum
added
I-nominated
P-high
T-compiler
labels
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Nominating; needs investigation and a fix. |
alexcrichton
assigned
nrc
Jul 27, 2017
nikomatsakis
removed
the
I-nominated
label
Jul 27, 2017
Mark-Simulacrum
added
the
C-bug
label
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
|
This might get fixed by #43230, although perhaps not (the example here is a 1.1 custom derive, but looking at 43230 I'm not sure if the filename makes sense, so I'm not convinced I know what it going on 100%) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
And the link to https://doc.servo.org/script/script_thread/struct.ScriptThread.html works. So I think this is fixed. @jdm please re-open if not. |
nrc
closed this
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
Aceeri
commented
Sep 9, 2017
|
I'm receiving this error when trying to run rustdoc here: https://travis-ci.org/amethyst/website#L935 I'm unable to reproduce locally, but others on macos/linux have been able to. Unsure if this is related to this or not however. |
jdm commentedJul 20, 2017
Running
./mach docon Servo's codebase yields a bunch of crates with the following warning:This means that the source is available for some types, but not others.
I'll try to figure out when this regressed.