Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land "add IntoFuture trait and support for await" #67982

Open
tmandry opened this issue Jan 7, 2020 · 3 comments
Open

Re-land "add IntoFuture trait and support for await" #67982

tmandry opened this issue Jan 7, 2020 · 3 comments

Comments

@tmandry
Copy link
Contributor

@tmandry tmandry commented Jan 7, 2020

#65244 was reverted in #67768 for performance reasons (see #67706). This issue tracks re-landing the support in a more performant way.

Tracking issue for IntoFuture trait: #67644

cc @seanmonstar @wesleywiser

@seanmonstar

This comment has been minimized.

Copy link
Contributor

@seanmonstar seanmonstar commented Jan 7, 2020

Sorry for my lack of rustc internal knowledge, is there any hint or guess at why it was slower?

@tmandry

This comment has been minimized.

Copy link
Contributor Author

@tmandry tmandry commented Jan 7, 2020

I don't think anyone knows for sure at this point. #67706 mentions normalize_ty_after_erasing_regions as the query that regressed.

cc @rust-lang/wg-traits

@tmandry

This comment has been minimized.

Copy link
Contributor Author

@tmandry tmandry commented Jan 14, 2020

In the @rust-lang/wg-async-await meeting we agreed that this was a nice to have, but would be good to get it over the finish line. Tagging this as OnDeck, because we'd like to look into it while people still remember the implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.