Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: when hiding item contents, include a count #85494

Closed
jsha opened this issue May 20, 2021 · 2 comments · Fixed by #87024
Closed

rustdoc: when hiding item contents, include a count #85494

jsha opened this issue May 20, 2021 · 2 comments · Fixed by #87024
Assignees
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented May 20, 2021

In #83337, we started hiding the contents (methods, fields, variants) of large traits, structs, and enums. When the contents are hidden there's text that says [+] Show methods. It's a little confusing as a user to figure out why some contents are hidden and some aren't. To improve that, we should include the number as a hint. E.g. [+] Show 15 methods.

/cc @Manishearth

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels May 20, 2021
@Manishearth
Copy link
Member

Oh this is a neat idea!

@weihanglo
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants