Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Margin below search results changes once the user starts typing a search in Safari #93184

Closed
camelid opened this issue Jan 22, 2022 · 5 comments · Fixed by #93188
Closed
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) C-bug Category: This is a bug. P-low Low priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@camelid
Copy link
Member

camelid commented Jan 22, 2022

Steps

  1. Open (desktop) Safari
  2. Click the search box here: https://doc.rust-lang.org/nightly/std/
  3. Type a letter
  4. Delete the letter
  5. Type another letter
  6. Notice how the empty space below the search bar changes size

cc @jsha – I think this is a recent regression; it's in nightly. I presume it has some connection to either your "All crates" change or your sidebar change. This bug is not present in beta.

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jan 22, 2022
@camelid camelid added this to the 1.60.0 milestone Jan 22, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 22, 2022
@jsha
Copy link
Contributor

jsha commented Jan 22, 2022 via email

@camelid
Copy link
Member Author

camelid commented Jan 22, 2022

I'm on Safari 15.2, though I'm not sure if it matters. I'll see if I can get a video sometime soon but I'm a bit busy right now.

@gelfand
Copy link

gelfand commented Jan 22, 2022

Screen.Recording.2022-01-22.at.5.09.23.AM.mov

@camelid
Copy link
Member Author

camelid commented Jan 22, 2022

Thanks!

@jsha
Copy link
Contributor

jsha commented Jan 22, 2022

Thanks for the video @gelfand, that really helped me figure out what I was looking for.

I was able to bisect it to 8abb4bb (moving the crate dropdown onto the search page).

Surprisingly, the minimum diff that causes the issue was not any of the CSS, but removing the dropdown element. So long as the search input has a previous sibling of any kind, the bumpiness does not happen. It's quite mysterious. I haven't been able to find a style that causes this.

@camelid camelid added P-low Low priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jan 22, 2022
@bors bors closed this as completed in cce8023 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) C-bug Category: This is a bug. P-low Low priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants