Remove Clean trait for ast::Attribute and improve Attributes::from_ast #100005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
C-cleanup
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
rust-highfive
added
the
S-waiting-on-review
notriddle
reviewed
Aug 1, 2022
…ibutes::from_ast function by splitting it in two
GuillaumeGomez
force-pushed
the
cleanup-ast-attr-clean
branch
from
cc8f827
to
04f570a
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#99987 (Always include a position span in `rustc_parse_format::Argument`) - rust-lang#100005 (Remove Clean trait for ast::Attribute and improve Attributes::from_ast) - rust-lang#100025 (Remove redundant `TransferWrapper` struct) - rust-lang#100045 (Properly reject the `may_unwind` option in `global_asm!`) - rust-lang#100052 (RISC-V ASM test: relax label name constraint.) - rust-lang#100053 (move [`assertions_on_result_states`] to restriction) - rust-lang#100057 (Remove more Clean trait implementations) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to keep this commit on its own for this PR because I'm changing a bit more things than expected originally: I split
Attributes::from_astinto two because there is only one location making use of its second parameter.Follow-up of #99638.
r? @notriddle