Rollup of 6 pull requests #100174
Merged
Rollup of 6 pull requests #100174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ref-for-binding-pattern, r=estebank Suggest adding/removing `ref` for binding patterns This fixes what a fixme comment says. r? `@estebank`
…ckh726 Use `node_type_opt` to skip over generics that were not expected Fixes rust-lang#100154
…d-of-repeated-push, r=Dylan-DPC rustdoc: use `collect()` instead of repeatedly pushing
…-98246, r=joshtriplett kmc-solid: Add a stub implementation of rust-lang#98246 (`File::set_times`) Fixes the build failure of the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets after rust-lang#98246. This target does not support setting a modification time and access time separately, hence stubbing out the implementation.
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
…or_missing_type_in_a_const_item, r=compiler-errors Improve diagnostics for `const a: = expr;` Adds a suggestion to write a type when there is a colon, but the type is not present. I've also shrunk spans a little, so the suggestions are a little nicer. Resolves rust-lang#100146 r? `@compiler-errors`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 5, 2022
|
Finished benchmarking commit (affe0d3): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
reffor binding patterns #99835 (Suggest adding/removingreffor binding patterns)node_type_optto skip over generics that were not expected #100155 (Usenode_type_optto skip over generics that were not expected)collect()instead of repeatedly pushing #100157 (rustdoc: usecollect()instead of repeatedly pushing)File::set_times) #100158 (kmc-solid: Add a stub implementation of Support setting file accessed/modified timestamps #98246 (File::set_times))const a: = expr;#100168 (Improve diagnostics forconst a: = expr;)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup