Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of typo #100707

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Fix a bunch of typo #100707

merged 3 commits into from
Sep 1, 2022

Conversation

dzvon
Copy link
Contributor

@dzvon dzvon commented Aug 18, 2022

This PR will fix some typos detected by typos.

I only picked the ones I was sure were spelling errors to fix, mostly in
the comments.

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 18, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in need_type_info.rs

cc @lcnr

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
5225225
5225225 reviewed Aug 18, 2022
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@davidtwco
Copy link
Member

r=me once @5225225's comment is addressed

@davidtwco
Copy link
Member

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned oli-obk Aug 18, 2022
@Dylan-DPC
Copy link
Member

@bors r=dawidtwco rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 18, 2022

📌 Commit 76d3a402c5200b4badff7d486273b46b78b78513 has been approved by dawidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2022
@davidtwco
Copy link
Member

Commit 76d3a40 has been approved by dawidtwco

There's an irony that my name gets typo'd in this PR of all PRs.

@davidtwco
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2022
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2022

📌 Commit 76d3a402c5200b4badff7d486273b46b78b78513 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 18, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 18, 2022
@bors
Copy link
Contributor

bors commented Aug 23, 2022

☔ The latest upstream changes (presumably #99917) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2022
@davidtwco
Copy link
Member

We have a no merge policy - could you rebase instead?

@Dylan-DPC
Copy link
Member

Are you sure you did it correctly? there are still conflicts to be resolved (you can see the conflicting files listed in the space below the CI checks)

@dzvon
Fix a bunch of typo
b1430fb 
This PR will fix some typos detected by [typos].

I only picked the ones I was sure were spelling errors to fix, mostly in
the comments.

[typos]: https://github.com/crate-ci/typos
@dzvon
Fix ci checks
85fc39c
@dzvon
Correct typo
1770693
@dzvon
Copy link
Contributor Author

dzvon commented Aug 31, 2022 •
edited
Loading

Are you sure you did it correctly? there are still conflicts to be resolved (you can see the conflicting files listed in the space below the CI checks)

Thanks for reminding, the previous push was to remove that merge commit. I believe this time it works.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2022

📌 Commit 1770693 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2022
@bors
Copy link
Contributor

bors commented Sep 1, 2022

⌛ Testing commit 1770693 with merge b32223f...

@bors
Copy link
Contributor

bors commented Sep 1, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing b32223f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2022
@bors bors merged commit b32223f into rust-lang:master Sep 1, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 1, 2022
@dzvon dzvon deleted the fix-typo branch September 1, 2022 08:08
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b32223f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-3.4%, -2.3%] 3
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [2.9%, 3.2%] 2
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Oct 23, 2022
@bors
Auto merge of rust-lang#100707 - dzvon:fix-typo, r=davidtwco
bfb2016 
Fix a bunch of typo

This PR will fix some typos detected by [typos].

I only picked the ones I was sure were spelling errors to fix, mostly in
the comments.

[typos]: https://github.com/crate-ci/typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5225225 5225225 5225225 left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dzvon @rust-highfive @rustbot @rust-log-analyzer @davidtwco @Dylan-DPC @bors @rust-timer @5225225 @oli-obk