Move Error trait into core #99917

yaahc · 2022-07-29T18:55:26Z

This PR moves the error trait from the standard library into a new unstable error module within the core library. The goal of this PR is to help unify error reporting across the std and no_std ecosystems, as well as open the door to integrating the error trait into the panic reporting system when reporting panics whose source is an errors (such as via expect).

This PR is a rewrite of #90328 using new compiler features that have been added to support error in core.

rustbot · 2022-07-29T18:55:29Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-07-29T18:55:29Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2022-08-02T06:32:42Z

☔ The latest upstream changes (presumably #99431) made this pull request unmergeable. Please resolve the merge conflicts.

yaahc · 2022-08-12T00:13:09Z

@bors try

bors · 2022-08-12T00:13:20Z

⌛ Trying commit ada65c2 with merge cc3bc286abf7599e6270f1e3b15ca478d68832e7...

bors · 2022-08-12T01:48:02Z

☀️ Try build successful - checks-actions
Build commit: cc3bc286abf7599e6270f1e3b15ca478d68832e7 (cc3bc286abf7599e6270f1e3b15ca478d68832e7)

library/core/src/convert/mod.rs

thomcc

This looks great and is super exciting to see. It seems the bulk of it is from other impls (which will be trimmed down once cfg(bootstrap) cleans up, so I don't really have any comments.

Sorry for the delay in reviewing it, it was fairly large!

thomcc · 2022-08-16T22:23:12Z

r=me with nit addressed

yaahc · 2022-08-17T20:58:23Z

Sorry for the delay in reviewing it, it was fairly large!

Entirely understandable, and thank you for slogging through it with me!

library/core/src/error.rs

library/core/src/error.md

yaahc · 2022-08-19T21:13:59Z

@bors r=thomcc

bors · 2022-08-19T21:14:00Z

📌 Commit 03861e5 has been approved by thomcc

It is now in the queue for this repository.

jhpratt · 2022-08-19T21:15:01Z

🎉 Long time coming! Great work Jane.

c410-f3r · 2022-08-19T21:51:05Z

Looking forward for core::io::Write.

rust-timer · 2022-08-23T23:47:02Z

Finished benchmarking commit (060e47f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[1.5%, 7.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩
number of relevant changes ↩

jhpratt · 2022-09-26T03:43:40Z

@yaahc Is there a tracking issue for this? I don't see any linked and there's not one in the error_in_core doc annotation.

Add tracking issue to `error_in_core` This was merged in rust-lang#99917 without a tracking issue, so I'm creating one now: rust-lang#103765

Summary: Added `fbcode` symlinks for `platform010` & `platform010-aarch64` and addressed the following fixes: * Account for stabilized [`#![feature(backtrace)]`](rust-lang/rust#99573) and [`#![feature(generic_associated_types)]`](rust-lang/rust#99573) * Account for removal of [`#![feature(result_into_ok_or_err)]`](rust-lang/rust#100604) * Account for migration of [`std::io::ReadBuf` to `std::io::BorrowBuf|BorrowCursor`](rust-lang/rust#97015) * Account for [`Error` trait move into core](rust-lang/rust#99917) * Account for `#[warn(non_camel_case_types)]` * Various function signature, lifetime requirement changes and lint fixes Reviewed By: zertosh Differential Revision: D40923615 fbshipit-source-id: f7ac2828d74edeae39aae517172207b0ee998a59

Summary: Added `fbcode` symlinks for `platform010` & `platform010-aarch64` and addressed the following fixes: * Account for stabilized [`#![feature(backtrace)]`](rust-lang/rust#99573) and [`#![feature(generic_associated_types)]`](rust-lang/rust#99573) * Account for removal of [`#![feature(result_into_ok_or_err)]`](rust-lang/rust#100604) * Account for migration of [`std::io::ReadBuf` to `std::io::BorrowBuf|BorrowCursor`](rust-lang/rust#97015) * Account for [`Error` trait move into core](rust-lang/rust#99917) * Account for `#[warn(non_camel_case_types)]` * Various function signature, lifetime requirement changes and lint fixes Test Plan: ``` cd ~/fbcode buckify_tp2 ./common/rust/tools/scripts/check_all.sh fbcode -- --local-only ``` Reviewed By: zertosh Differential Revision: D40923615 fbshipit-source-id: f7ac2828d74edeae39aae517172207b0ee998a59

Add tracking issue to `error_in_core` This was merged in rust-lang/rust#99917 without a tracking issue, so I'm creating one now: rust-lang/rust#103765

rust-highfive assigned thomcc Jul 29, 2022

rustbot added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 29, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022

yaahc changed the title ~~Error in core move~~ Move Error trait into core Jul 29, 2022

This comment has been minimized.

Sign in to view

yaahc force-pushed the error-in-core-move branch from 33bc19f to b42d648 Compare August 2, 2022 23:59

This comment has been minimized.

Sign in to view

coolreader18 reviewed Aug 14, 2022

View reviewed changes

library/core/src/convert/mod.rs Show resolved Hide resolved

thomcc approved these changes Aug 16, 2022

View reviewed changes

yaahc commented Aug 17, 2022

View reviewed changes

library/core/src/error.rs Outdated Show resolved Hide resolved

yaahc commented Aug 17, 2022

View reviewed changes

library/core/src/error.md Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022

rustbot added this to the 1.65.0 milestone Aug 23, 2022

This was referenced Aug 23, 2022

Disable unwinding for catch_unwind error payloads. #99032

Open

Fix a bunch of typo #100707

Merged

c410-f3r mentioned this pull request Aug 23, 2022

Using std::io::{Read, Write, Cursor} in a nostd environment #48331

Open

TimDiekmann mentioned this pull request Sep 7, 2022

Support core::error::Error hashintel/hash#1038

Merged

mooman219 mentioned this pull request Sep 12, 2022

#![no_std] support pdeljanov/Symphonia#88

Open

thomcc mentioned this pull request Oct 18, 2022

std::error::Error docs don't mention e.downcast() (only downcast_{ref,mut}) #103170

Closed

This was referenced Oct 30, 2022

Tracking Issue for Error in core #103765

Closed

Add tracking issue to error_in_core #103766

Merged

slanterns mentioned this pull request Nov 11, 2022

Move IpAddr, SocketAddr and V4+V6 related types to core #104265

Merged

tspiteri mentioned this pull request Dec 24, 2022

release notes for 1.65.0 did not mention moving Error trait into core #106122

Closed

bjorn3 mentioned this pull request Feb 26, 2023

Tracking issue for RFC 2504, "Fix the Error trait" #53487

Open

9 tasks

waynexia mentioned this pull request Mar 9, 2023

chore: deduplicate workspace fields in Cargo.toml apache/datafusion#5519

Merged

dead-claudia mentioned this pull request Apr 7, 2023

Expose the internal SimpleMessage struct and allow creating std::io::Errors with them rust-lang/libs-team#205

Open

Enselic mentioned this pull request Dec 17, 2023

Consider moving std::error::Error to alloc #62502

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Error trait into core #99917

Move Error trait into core #99917

yaahc commented Jul 29, 2022 •

edited

Loading

rustbot commented Jul 29, 2022

rust-highfive commented Jul 29, 2022

This comment has been minimized.

bors commented Aug 2, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

yaahc commented Aug 12, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

thomcc left a comment

thomcc commented Aug 16, 2022

yaahc commented Aug 17, 2022

This comment has been minimized.

yaahc commented Aug 19, 2022

bors commented Aug 19, 2022

jhpratt commented Aug 19, 2022 •

edited

Loading

c410-f3r commented Aug 19, 2022

rust-timer commented Aug 23, 2022

jhpratt commented Sep 26, 2022

Move Error trait into core #99917

Move Error trait into core #99917

Conversation

yaahc commented Jul 29, 2022 • edited Loading

rustbot commented Jul 29, 2022

rust-highfive commented Jul 29, 2022

This comment has been minimized.

bors commented Aug 2, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

yaahc commented Aug 12, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

thomcc left a comment

Choose a reason for hiding this comment

thomcc commented Aug 16, 2022

yaahc commented Aug 17, 2022

This comment has been minimized.

yaahc commented Aug 19, 2022

bors commented Aug 19, 2022

jhpratt commented Aug 19, 2022 • edited Loading

c410-f3r commented Aug 19, 2022

rust-timer commented Aug 23, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

jhpratt commented Sep 26, 2022

yaahc commented Jul 29, 2022 •

edited

Loading

jhpratt commented Aug 19, 2022 •

edited

Loading