Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate part of rustc_infer to session diagnostic #100843

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Migrate part of rustc_infer to session diagnostic #100843

merged 7 commits into from
Aug 29, 2022

Conversation

IntQuant
Copy link
Contributor

No description provided.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2022
@IntQuant
Copy link
Contributor Author

@rustbot label +A-translation

r? rust-lang/diagnostics
cc #100717

davidtwco
davidtwco requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, thanks for working on it, I've left a couple comments.

compiler/rustc_infer/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/infer/error_reporting/mod.rs Show resolved Hide resolved
@davidtwco
Copy link
Member

r? @davidtwco

@davidtwco davidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@IntQuant IntQuant changed the title Migrate rustc_infer to session diagnostic Migrate part of rustc_infer to session diagnostic Aug 24, 2022
@IntQuant IntQuant marked this pull request as ready for review August 24, 2022 13:38
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in need_type_info.rs

cc @lcnr

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit e1765a9 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 26, 2022

📌 Commit e1765a9 has been approved by compiler-errors

It is now in the queue for this repository.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
1e2f33c 
…piler-errors

Migrate part of rustc_infer to session diagnostic
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 28, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
4da9d76 
…piler-errors

Migrate part of rustc_infer to session diagnostic
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 28, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
a8b63a4 
…piler-errors

Migrate part of rustc_infer to session diagnostic
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 28, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
a722e77 
…piler-errors

Migrate part of rustc_infer to session diagnostic
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 28, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
36f372e 
…piler-errors

Migrate part of rustc_infer to session diagnostic
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 28, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2022
@bors
Auto merge of rust-lang#101143 - matthiaskrgr:rollup-g8y5k0g, r=matth…
94b2b15 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#94890 (Support parsing IP addresses from a byte string)
 - rust-lang#96334 (socket `set_mark` addition.)
 - rust-lang#99027 (Replace `Body::basic_blocks()` with field access)
 - rust-lang#100437 (Improve const mismatch `FulfillmentError`)
 - rust-lang#100843 (Migrate part of rustc_infer to session diagnostic)
 - rust-lang#100897 (extra sanity check against consts pointing to mutable memory)
 - rust-lang#100959 (translations: rename warn_ to warning)
 - rust-lang#101111 (Use the declaration's SourceInfo for FnEntry retags, not the outermost)
 - rust-lang#101116 ([rustdoc] Remove Attrs type alias)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3c965f into rust-lang:master Aug 29, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@IntQuant @rust-highfive @davidtwco @rustbot @bors @compiler-errors @estebank