rustdoc: don't ICE on TyKind::Typeof
#103006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
no test? 😞 |
|
I've added a test, is it better now, sweetheart? 🥺 @matthiaskrgr |
|
<3 😂 |
bors
added
S-waiting-on-bors
| @@ -0,0 +1,4 @@ | |||
| struct Struct { | |||
| y: (typeof("hey"),), | |||
| //~^ `typeof` is a reserved keyword but unimplemented | |||
There was a problem hiding this comment.
For future reference, I think it's conventional to do //~^ ERROR just to make sure we're asserting the kind of diagnostic here
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 13, 2022
…ler-errors rustdoc: don't ICE on `TyKind::Typeof` Fixes rust-lang#102986 I'm not sure why rustdoc started seeing `TyKind::Typeof` all of a sudden (the code being editted was last touched 3 months ago), probably something to do with error recovery? idk.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103000 (Add suggestion to the "missing native library" error) - rust-lang#103006 (rustdoc: don't ICE on `TyKind::Typeof`) - rust-lang#103008 (replace ReErased with fresh region vars in opaque types) - rust-lang#103011 (Improve rustdoc `unsafe-fn` GUI test) - rust-lang#103013 (Add new bootstrap entrypoints to triagebot) - rust-lang#103016 (Ensure enum cast moves) - rust-lang#103021 (Add links to relevant pages to find constraint information) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102986
I'm not sure why rustdoc started seeing
TyKind::Typeofall of a sudden (the code being editted was last touched 3 months ago), probably something to do with error recovery? idk.