Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize main_separator_str #103104

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Stabilize main_separator_str #103104

merged 1 commit into from
Jan 8, 2023

Conversation

SUPERCILEX
Copy link
Contributor

See reasoning here: #94071 (comment). Closes #94071.

@SUPERCILEX
Stabilize main_separator_str
b8d560c 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 16, 2022
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@SUPERCILEX
Copy link
Contributor Author

r? @yaahc

@rust-highfive rust-highfive assigned yaahc and unassigned m-ou-se Oct 16, 2022
@SUPERCILEX
Copy link
Contributor Author

@rfcbot merge

@SUPERCILEX
Copy link
Contributor Author

Hmmm, looks like randos can't use the bot. No idea what the process is to request an FCP.

@Nilstrieb
Copy link
Member

Someone from T-libs-api needs to start the FCP

@SUPERCILEX
Copy link
Contributor Author

@Nilstrieb got it, thanks. It it ok to have this PR open then? Is it basically the equivalent of requesting someone consider starting an FCP?

@ChrisDenton
Copy link
Contributor

Usually an fcp happens on the tracking issue before a stabilization PR is created because it can take a while to complete (iirc a minimum of 10 days, usually longer though). It's fine to have this PR open but it means you may have to rebase if other changes are made in the repository while the fcp is pending. Also it should be labelled as T-libs-api (which can be done using rustbot),

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2022
@SUPERCILEX
Copy link
Contributor Author

@ChrisDenton thanks for the explanation! I'll just leave this open since conflicts would be trivial to resolve.

@SUPERCILEX
Copy link
Contributor Author

r?

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2022

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@SUPERCILEX
Copy link
Contributor Author

r? libs

@rustbot rustbot assigned m-ou-se and unassigned yaahc Nov 16, 2022
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Dec 13, 2022 •
edited by BurntSushi
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 13, 2022
@dtolnay
Copy link
Member

dtolnay commented Dec 20, 2022

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this PR got proposed for FCP.

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 28, 2022
@rfcbot
Copy link

rfcbot commented Dec 28, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 7, 2023
@rfcbot
Copy link

rfcbot commented Jan 7, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jan 7, 2023
@dtolnay dtolnay assigned dtolnay and unassigned m-ou-se Jan 7, 2023
@dtolnay
Copy link
Member

dtolnay commented Jan 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 7, 2023

📌 Commit b8d560c has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2023
@SUPERCILEX
Copy link
Contributor Author

Woohoo, thanks!

JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 8, 2023
Rollup merge of rust-lang#103104 - SUPERCILEX:sep-ref, r=dtolnay
4aac9b0 
Stabilize `main_separator_str`

See reasoning here: rust-lang#94071 (comment). Closes rust-lang#94071.
This was referenced Jan 8, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2023
@bors
Auto merge of rust-lang#106588 - JohnTitor:rollup-4z80tjx, r=JohnTitor
8ea62f6 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#103104 (Stabilize `main_separator_str`)
 - rust-lang#106410 (Suggest `mut self: &mut Self` for `?Sized` impls)
 - rust-lang#106457 (Adjust comments about pre-push.sh hook)
 - rust-lang#106546 (jsondoclint: Check local items in `paths` are also in `index`.)
 - rust-lang#106557 (Add some UI tests and reword error-code docs)
 - rust-lang#106562 (Clarify examples for `VecDeque::get/get_mut`)
 - rust-lang#106580 (remove unreachable error code `E0313`)
 - rust-lang#106581 (Do not emit wrong E0308 suggestion for closure mismatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed77ffe into rust-lang:master Jan 8, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 8, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for MAIN_SEPARATOR_STR