Skip to content

Conversation

notriddle
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Failed to set assignee to CraftSpider: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/scraped-example-list-font branch from 0d3a6bf to 2af2d8d Compare December 1, 2022 19:16
@notriddle notriddle force-pushed the notriddle/scraped-example-list-font branch 2 times, most recently from 0883d81 to bef7c25 Compare December 1, 2022 19:20
@notriddle notriddle force-pushed the notriddle/scraped-example-list-font branch from bef7c25 to 935def4 Compare December 1, 2022 19:34
@@ -0,0 +1,8 @@
goto: "file://" + |DOC_PATH| + "/scrape_examples/fn.test_many.html"

store-value: (font, '"Fira Sans", Arial, NanumBarunGothic, sans-serif')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of variables! 👍

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 1, 2022

📌 Commit 935def4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#104614 (Add `type_ascribe!` macro as placeholder syntax for type ascription)
 - rust-lang#105126 (Make `VecDeque::new_in` unstably const)
 - rust-lang#105132 (Migrate summary toggle filter to CSS variable)
 - rust-lang#105136 (clarify comment on Deref promotion)
 - rust-lang#105137 (Add tracking issue number for `file_create_new` feature)
 - rust-lang#105143 (rustdoc: use simpler CSS for setting the font on scraped examples)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8e059d5 into rust-lang:master Dec 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 2, 2022
@notriddle notriddle deleted the notriddle/scraped-example-list-font branch December 2, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants