Auto traits in dyn Trait + Auto are suggestable
#105627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #104986) made this pull request unmergeable. Please resolve the merge conflicts. |
davidtwco
approved these changes
Dec 14, 2022
|
r=me after conflicts resolved |
compiler-errors
force-pushed
the
dyn-auto-suggestable
branch
from
ac6f56d
to
cfa6a93
Compare
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2022
…le, r=davidtwco Auto traits in `dyn Trait + Auto` are suggestable Not sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable. It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2022
…le, r=davidtwco Auto traits in `dyn Trait + Auto` are suggestable Not sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable. It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 15, 2022
…le, r=davidtwco Auto traits in `dyn Trait + Auto` are suggestable Not sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable. It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 15, 2022
…le, r=davidtwco Auto traits in `dyn Trait + Auto` are suggestable Not sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable. It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104592 (Ensure async trait impls are async (or otherwise return an opaque type)) - rust-lang#105623 (Fix `-Z print-type-sizes` for generators with discriminant field ordered first) - rust-lang#105627 (Auto traits in `dyn Trait + Auto` are suggestable) - rust-lang#105633 (Make `report_projection_error` more `Term` agnostic) - rust-lang#105683 (Various cleanups to dest prop) - rust-lang#105692 (Add regression test for rust-lang#104678) - rust-lang#105707 (rustdoc: remove unnecessary CSS `kbd { cursor: default }`) - rust-lang#105715 (Do not mention long types in E0599 label) - rust-lang#105722 (more clippy::complexity fixes) - rust-lang#105724 (rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`) - rust-lang#105730 (rustdoc: remove no-op CSS `.item-info:before { color }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why I had made the
IsSuggestableVisitorhave that rule to not considerdyn Trait + Autoto be suggestable.It's possible that this was done because of the fact that we don't print the right parentheses for
&(dyn Trait + Auto), but that's a problem with printing these types in general that we probably have tracked somewhere else...