Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make report_projection_error more Term agnostic #105633

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Make report_projection_error more Term agnostic #105633

merged 1 commit into from
Dec 15, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #105632

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2022
compiler-errors
compiler-errors commented Dec 12, 2022
View reviewed changes
compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs
def: ty::WithOptConstParam::unknown(data.projection_ty.item_def_id),
substs: data.projection_ty.substs,
},
ct.ty(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the type from the expected const, but we don't carry the type from the LHS of the projection equality predicate. Anyways, not a huge issue, since we always expect these types to be equal (we assert for it in other places, I'm pretty sure).

src/test/ui/associated-type-bounds/const-projection-err.stock.stderr
| ^ expected `1`, found `<T as TraitWAssocConst>::A`
|
= note: expected constant `1`
found constant `<T as TraitWAssocConst>::A`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange and sad that we don't normalize this unless generic_const_exprs is enabled, but this isn't related to the ICE.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 13, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2022

📌 Commit 4935ff583a737c8b4bedc8b1cb9e7d8bd58ee3c8 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
@bors
Copy link
Contributor

bors commented Dec 14, 2022

☔ The latest upstream changes (presumably #104986) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2022
@compiler-errors
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 14, 2022

📌 Commit 7bf36de has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#105633 - compiler-errors:term-agnostic, r=o…
ae6dfa6 
…li-obk

Make `report_projection_error` more `Term` agnostic

Fixes rust-lang#105632
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#105633 - compiler-errors:term-agnostic, r=o…
d2b716d 
…li-obk

Make `report_projection_error` more `Term` agnostic

Fixes rust-lang#105632
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2022
@matthiaskrgr
Rollup merge of rust-lang#105633 - compiler-errors:term-agnostic, r=o…
b9e0d60 
…li-obk

Make `report_projection_error` more `Term` agnostic

Fixes rust-lang#105632
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2022
@matthiaskrgr
Rollup merge of rust-lang#105633 - compiler-errors:term-agnostic, r=o…
968b053 
…li-obk

Make `report_projection_error` more `Term` agnostic

Fixes rust-lang#105632
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2022
@bors
Auto merge of rust-lang#105746 - matthiaskrgr:rollup-sz3grbv, r=matth…
984eab5 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#104592 (Ensure async trait impls are async (or otherwise return an opaque type))
 - rust-lang#105623 (Fix `-Z print-type-sizes` for generators with discriminant field ordered first)
 - rust-lang#105627 (Auto traits in `dyn Trait + Auto` are suggestable)
 - rust-lang#105633 (Make `report_projection_error` more `Term` agnostic)
 - rust-lang#105683 (Various cleanups to dest prop)
 - rust-lang#105692 (Add regression test for rust-lang#104678)
 - rust-lang#105707 (rustdoc: remove unnecessary CSS `kbd { cursor: default }`)
 - rust-lang#105715 (Do not mention long types in E0599 label)
 - rust-lang#105722 (more clippy::complexity fixes)
 - rust-lang#105724 (rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`)
 - rust-lang#105730 (rustdoc: remove no-op CSS `.item-info:before { color }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 78cf8cc into rust-lang:master Dec 15, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 15, 2022
@compiler-errors compiler-errors deleted the term-agnostic branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

ICE with mismatch in trait associated constant
4 participants
@compiler-errors @rustbot @oli-obk @bors