Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax reference requirement on SocketAddrExt::from_abstract_name #106441

Merged
merged 1 commit into from
Jan 18, 2023
Merged

relax reference requirement on SocketAddrExt::from_abstract_name #106441

merged 1 commit into from
Jan 18, 2023

Conversation

mllken
Copy link
Contributor

@mllken mllken commented Jan 4, 2023

Reference: #85410 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@mllken
Copy link
Contributor Author

mllken commented Jan 4, 2023

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2023
@Mark-Simulacrum Mark-Simulacrum added the I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. label Jan 14, 2023
@Mark-Simulacrum
Copy link
Member

Nominating for libs-api. This PR looks good to me, but I note that in the FCP to stabilize this feature (#85410 (comment)) the description of the tracking issue does not include AsRef<[u8]> at all, so it's probably worth bringing that to your attention before moving forward with stabilization or this PR. (To avoid stabilizing something that folks may have not looked at in terms of exact API).

r=me once libs-api takes a look though presuming no objections are raised

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2023

📌 Commit ee59533 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 17, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 18, 2023
@compiler-errors
Rollup merge of rust-lang#106441 - mllken:abstract-socket-noref, r=jo…
b9ce633 
…shtriplett

relax reference requirement on SocketAddrExt::from_abstract_name

Reference: rust-lang#85410 (comment)
@compiler-errors compiler-errors mentioned this pull request Jan 18, 2023
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2023
@bors
Auto merge of rust-lang#107026 - Dylan-DPC:rollup-4fonvdc, r=Dylan-DPC
1f72129 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#103702 (Lift `T: Sized` bounds from some `strict_provenance` pointer methods)
 - rust-lang#106441 (relax reference requirement on SocketAddrExt::from_abstract_name)
 - rust-lang#106718 (finish trait solver skeleton work)
 - rust-lang#106950 (Don't do pointer arithmetic on pointers to deallocated memory)
 - rust-lang#107014 (rustdoc: remove deprecated / unused code from main.js)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 548ae60 into rust-lang:master Jan 18, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 18, 2023
@JohnTitor JohnTitor mentioned this pull request Feb 21, 2023
Closed
4 tasks
@dtolnay dtolnay removed the I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mllken @rustbot @Mark-Simulacrum @joshtriplett @bors @dtolnay