Stop having unused lifetimes on some impls
#106799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2023
Rollup of 13 pull requests Successful merges: - rust-lang#104965 (reword Option::as_ref and Option::map examples) - rust-lang#105172 (Added error documentation for write_fmt) - rust-lang#106605 (rustdoc: fix outdated lint section of the book) - rust-lang#106670 (Check compiler docs in PR CI) - rust-lang#106692 (mv binary_heap.rs binary_heap/mod.rs) - rust-lang#106693 (rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle) - rust-lang#106707 (Remove duplicate sha-1 dependency) - rust-lang#106762 (Add `AtomicPtr::as_mut_ptr`) - rust-lang#106766 (Remove dead code in rustdoc stripper) - rust-lang#106775 (Remove stale reference to the test suite location) - rust-lang#106799 (Stop having unused lifetimes on some `impl`s) - rust-lang#106816 (Update `rental` hack to work with remapped paths.) - rust-lang#106819 (rustdoc: remove unnecessary DOM class `h1.fqn`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://doc.rust-lang.org/nightly/std/cmp/trait.PartialOrd.html#impl-PartialOrd%3COsStr%3E-for-PathBuf, where these lifetimes show up even though they're not needed:
With this PR, the unneeded lifetimes are no longer there:
